fix(settings): Improve mail test error handling and logging #56862
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavohri
requested review from
icewind1991,
nfebe,
sorbaugh,
szaimen and
yemkareems
and removed request for
a team
szaimen
approved these changes
Dec 5, 2025
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Tested and works!
Thanks a lot for fixing this!
Contributor
|
/backport to stable32 |
Contributor
|
/backport to stable31 |
provokateurin
requested changes
Dec 5, 2025
provokateurin
approved these changes
Dec 6, 2025
Member
|
@abhinavohri you don't need to update the branch unless there are conflicts. Please squash your commits and make sure the commit message follows https://www.conventionalcommits.org/en/v1.0.0/. |
Signed-off-by: Abhinav Ohri <[email protected]>
abhinavohri
commented
Dec 7, 2025
Signed-off-by: Abhinav Ohri <[email protected]>
provokateurin
approved these changes
Dec 7, 2025
Member
|
@abhinavohri you need to adjust the tests to account for the new parameter you added to the class constructor. |
…r test Signed-off-by: Abhinav Ohri <[email protected]>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the error handling and logging when testing email settings by showing informative error message on frontend and in the server logs.
Before
After
TODO
Checklist
3. to review, feature component)stable32)